-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guile-ssh: 0.16.3 -> 0.17.0-unstable-2024-10-15 #348857
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
labels
Oct 15, 2024
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4686 |
leungbk
force-pushed
the
guile-ssh-update
branch
from
October 17, 2024 17:30
9f4201b
to
ba0bb36
Compare
leungbk
force-pushed
the
guile-ssh-update
branch
from
October 19, 2024 17:37
ba0bb36
to
64ef946
Compare
leungbk
changed the title
guile-ssh: 0.16.3 -> unstable-2024-10-15
guile-ssh: 0.16.3 -> 0.17.0-unstable-2024-10-15
Oct 19, 2024
ethancedwards8
approved these changes
Oct 19, 2024
phanirithvij
added
12.approvals: 2
This PR was reviewed and approved by two reputable people
12.approved-by: package-maintainer
This PR was reviewed and approved by a maintainer listed in the package
labels
Oct 20, 2024
wegank
added
12.approvals: 1
This PR was reviewed and approved by one reputable person
and removed
12.approvals: 2
This PR was reviewed and approved by two reputable people
labels
Oct 20, 2024
phanirithvij
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
guix builds and works as expected
phanirithvij
added
12.approvals: 2
This PR was reviewed and approved by two reputable people
and removed
12.approvals: 1
This PR was reviewed and approved by one reputable person
labels
Oct 22, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
12.approvals: 2
This PR was reviewed and approved by two reputable people
12.approved-by: package-maintainer
This PR was reviewed and approved by a maintainer listed in the package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the build failure seen at https://hydra.nixos.org/build/273797767/nixlog/1
cc @ethancedwards8 @foo-dogsquared
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.