Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guile-ssh: 0.16.3 -> 0.17.0-unstable-2024-10-15 #348857

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

leungbk
Copy link
Member

@leungbk leungbk commented Oct 15, 2024


Fixes the build failure seen at https://hydra.nixos.org/build/273797767/nixlog/1

cc @ethancedwards8 @foo-dogsquared

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4686

@leungbk leungbk changed the title guile-ssh: 0.16.3 -> unstable-2024-10-15 guile-ssh: 0.16.3 -> 0.17.0-unstable-2024-10-15 Oct 19, 2024
@phanirithvij phanirithvij added 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Oct 20, 2024
@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person and removed 12.approvals: 2 This PR was reviewed and approved by two reputable people labels Oct 20, 2024
Copy link
Member

@phanirithvij phanirithvij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

guix builds and works as expected

@phanirithvij phanirithvij added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Oct 22, 2024
@SuperSandro2000 SuperSandro2000 merged commit e826e3d into NixOS:master Oct 25, 2024
37 checks passed
@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 348857


x86_64-linux

✅ 2 packages built:
  • guile-ssh
  • guix

aarch64-linux

✅ 2 packages built:
  • guile-ssh
  • guix

x86_64-darwin

✅ 1 package built:
  • guile-ssh

aarch64-darwin

✅ 1 package built:
  • guile-ssh

@leungbk leungbk deleted the guile-ssh-update branch October 25, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 12.approvals: 2 This PR was reviewed and approved by two reputable people 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants