Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

krun: init at 0-unstable-2024-06-18 #321359

Merged
merged 3 commits into from
Jul 24, 2024
Merged

krun: init at 0-unstable-2024-06-18 #321359

merged 3 commits into from
Jul 24, 2024

Conversation

RossComputerGuy
Copy link
Member

@RossComputerGuy RossComputerGuy commented Jun 20, 2024

Description of changes

Updates libkrun and libkrunfw, adds krun. Good way to test is NIXOS_CURRENT_SYSTEM=$(readlink -e /run/current-system/) ./result/bin/krun bash

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Sorry, something went wrong.

@RossComputerGuy RossComputerGuy force-pushed the feat/krun branch 2 times, most recently from 34cdf16 to 7a7f7de Compare June 20, 2024 22:54
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Jun 20, 2024
@ofborg ofborg bot requested a review from NickCao June 20, 2024 23:24
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Jun 20, 2024
flokli
flokli previously requested changes Jun 21, 2024
pkgs/by-name/kr/krun/package.nix Show resolved Hide resolved
pkgs/by-name/kr/krun/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/kr/krun/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/kr/krun/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/kr/krun/package.nix Outdated Show resolved Hide resolved
@RossComputerGuy RossComputerGuy changed the title krun: init at 0.0.0-unstable-2024-06-18 krun: init at 0-unstable-2024-06-18 Jun 21, 2024
@RossComputerGuy
Copy link
Member Author

Found out a rebase fixed libkrun's hash.

@RossComputerGuy RossComputerGuy force-pushed the feat/krun branch 2 times, most recently from b49b954 to 2a62915 Compare June 25, 2024 04:36
@RossComputerGuy
Copy link
Member Author

Ok, now it actually works after I juggle the hashes around. Seems they all got shuffled.

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 4, 2024
@RossComputerGuy RossComputerGuy removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jul 5, 2024
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jul 5, 2024
@Aleksanaa
Copy link
Member

7 packages built:
krun krunvm libkrun libkrun-sev libkrun-sev.dev libkrun.dev libkrunfw

@Aleksanaa
Copy link
Member

=> NIXOS_CURRENT_SYSTEM=$(readlink -e /run/current-system/) krun bash
No IPv6 nameserver available for NDP/DHCPv6

So I've been stuck at here for about 10 minutes. Will check later

@RossComputerGuy
Copy link
Member Author

So I've been stuck at here for about 10 minutes. Will check later

Maybe try spinning up a paast socket or a different command?

--passt-socket=PATH  Instead of starting passt, connect to passt socket at PATH

@tomberek
Copy link
Contributor

Result of nixpkgs-review pr 321359 run on x86_64-linux 1

7 packages built:
  • krun
  • krunvm
  • libkrun
  • libkrun-sev
  • libkrun-sev.dev
  • libkrun.dev
  • libkrunfw

@tomberek tomberek merged commit 69c850c into NixOS:master Jul 24, 2024
29 of 30 checks passed
@RossComputerGuy RossComputerGuy deleted the feat/krun branch July 24, 2024 03:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants