-
-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aw-watcher-window-wayland: fix version of rustc-serialize #310125
Conversation
The bundled version of rustc-serialize can not be compiled with Rust versions starting with 1.76.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the things proposed in ActivityWatch/aw-watcher-window-wayland#36.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me since it fixes the build issue.
I no longer use this software since it stopped supporting hyprland.
I attempted to test functionality using sway, but it is also dropped. I then quickly attempted to set it up on KDE and Phosh but did not get anything to work.
The project itself has not seen any activity for 7 months and also suggests people to use a different project ActivityWatch/aw-watcher-window-wayland#34.
The program did build and launch but since neither hyprland nor sway expose the idle object that it needs it exits, but that behavior is not related to this PR.
thread 'main' panicked at src/idle.rs:79:10:
Wayland session does not expose a Idle object, this window manager is most likely not supported: Missing
Results of nixpkgs-review is
1 package built:
aw-watcher-window-wayland
I tested the package with Phosh, the only other platform which is supported. I started the 'aw-server-rust'. Under Phosh, ' Tested with the configuration services.xserver.desktopManager.phosh = {
enable = true;
user = "jonas";
group = "users";
};
services.xserver = {
enable = true;
}; In order to run, disable all other desktop/window and login managers. Phosh will boot itself right away. The passcode is your user password, use your keyboard for that. I could only run Emacs for some reason, but that was enough to start this package without an exception. |
Running Phosh was not the issue but If To check this go to the activitywatch timeline . If you can not start a browser in Phosh you can also try to query with
|
Contains the same fix as in NixOS#310673 and NixOS#310125 that allows it to build on Rust >1.76. However, I think this patch might have to be a permanent one as upstream has been abandoned and unmaintained. Also removed some spurious `with lib;` and `rec` use, moved to use `pkgs/by-name` and reformatted using `nixfmt-rfc-style`.
The bundled version of rustc-serialize can not be compiled with Rust versions starting with 1.76.0.
Description of changes
#309482
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.