frozen: init at unstable-2021-02-23 #248326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thillux
force-pushed
the
frozen
branch
2 times, most recently
from
3cb8840 to
63c2faf
Compare
nikstur
reviewed
Aug 10, 2023
Comment on lines
22
to
26
| # frozen only has internal make and bazel support | ||
| # as it only consists of two source files, adding a | ||
| # small meson file on the fly is the easiest option for | ||
| # cross compilation support |
There was a problem hiding this comment.
Would it be feasible to get this support upstream? Even if not, it'd probably be better to open a PR and pull in the patch via the GitHub API from the PR.
There was a problem hiding this comment.
If the PR gets closed, the patch disappears though — learned this the hard way with ZFS :D.
ofborg
bot
added
8.has: package (new)
|
I added comments on the issue and possible release, as I can't predict when/if that will happen upstream. |
AndersonTorres
suggested changes
Aug 10, 2023
thillux
force-pushed
the
frozen
branch
2 times, most recently
from
dd6f807 to
b0491d8
Compare
|
Not about our package but the upstream itself: it looks they stalled a lot of time ago. |
AndersonTorres
suggested changes
Aug 11, 2023
nikstur
reviewed
Aug 11, 2023
nikstur
approved these changes
Aug 11, 2023
AndersonTorres
approved these changes
Aug 11, 2023
frozen is a small JSON parser and generator library, targeted at embedded use-cases. As it only uses two source files, add meson.build on the fly to enable cross compilation. Signed-off-by: Markus Theil <[email protected]>
RaitoBezarius
approved these changes
Aug 11, 2023
nikstur
added
the
12.approvals: 3+
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
frozen is a small JSON parser and generator library, targeted at embedded use-cases. As it only uses two source files, add meson.build on the fly to enable cross compilation.
Description of changes
Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)