Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

n8n: remove systemd option incompatible with nodejs #139632

Merged
merged 1 commit into from
Sep 29, 2021
Merged

n8n: remove systemd option incompatible with nodejs #139632

merged 1 commit into from
Sep 29, 2021

Conversation

purcell
Copy link
Member

@purcell purcell commented Sep 27, 2021

Motivation for this change

The MemoryDenyWriteExecute systemd option is widely known to be incompatible with nodejs, and causes service crashes as reported in #119687.

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • 21.11 Release Notes (or backporting 21.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Sep 27, 2021
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Sep 27, 2021
@purcell
Copy link
Member Author

purcell commented Sep 27, 2021

I've confirmed that mkForce-ing this option to "no" fixes the related issue, so this should be the correct fix. I haven't built exactly this change on the corresponding machine though, sorry. Understand if that's a blocker, but I think there's no danger here, so submitting as-is for now.

@alyssais
Copy link
Member

The MemoryDenyWriteExecute systemd option is widely known to be incompatible with nodejs, and causes service crashes as reported in #119687.

Please include detail like this in your commit message as well as the PR body. It makes it much easier to review history in the future, and will remain accessible forever in git history, whereas one day GitHub might be gone. :)

@purcell purcell force-pushed the systemd-n8n-remove-systemd-option branch from 660d605 to 0242530 Compare September 27, 2021 14:36
@purcell
Copy link
Member Author

purcell commented Sep 27, 2021

Please include detail like this in your commit message as well as the PR body. It makes it much easier to review history in the future, and will remain accessible forever in git history, whereas one day GitHub might be gone. :)

Yes, good point - done, thanks!

@purcell
n8n: remove systemd option incompatible with nodejs
024cd34 
The MemoryDenyWriteExecute systemd option is widely known to be
incompatible with nodejs, and causes service crashes as reported in NixOS#119687.

Fixes NixOS#119687.
@purcell purcell force-pushed the systemd-n8n-remove-systemd-option branch from 0242530 to 024cd34 Compare September 27, 2021 16:50
@alyssais
Copy link
Member

@ofborg test n8n

@alyssais alyssais merged commit 4b518f4 into NixOS:master Sep 29, 2021
@purcell
Copy link
Member Author

purcell commented Sep 30, 2021

Thank you @alyssais!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baloo baloo baloo requested changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@purcell @alyssais @baloo