Allow overwriting the version with a .version file #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinisil
reviewed
Aug 7, 2024
main/Main.hs
Outdated
| versionFromFile :: String | ||
| versionFromFile = case $(embedFileIfExists ".version") of | ||
| Just ver -> unpack ver | ||
| _ -> showVersion version |
There was a problem hiding this comment.
Although, hold on, there's a spurious warning when compiling:
main/Main.hs:54:3: warning: [-Woverlapping-patterns]
Pattern match is redundant
In a case alternative: Just ver -> ...
|
54 | Just ver -> unpack ver
| ^^^^^^^^^^^^^^^^^^^^^^
Investigating..
To avoid this warning:
main/Main.hs:54:3: warning: [-Woverlapping-patterns]
Pattern match is redundant
In a case alternative: Just ver -> ...
|
54 | Just ver -> unpack ver
| ^^^^^^^^^^^^^^^^^^^^^^
Which happens because to the compiler, the Template Haskell expression
looks like a constant, always making one pattern redundant.
It won't dig into that if we use a function on it though :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#229