-
-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure formatted Nix and Haskell files #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
piegamesde
approved these changes
Apr 16, 2024
We looked at this in the team meeting:
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/formatting-team-meeting-2024-04-16/43533/1 |
infinisil
force-pushed
the
treefmt
branch
2 times, most recently
from
April 17, 2024 20:59
9610b51
to
d8dff38
Compare
@piegamesde Now using fourmolu, please merge if it looks good :) |
piegamesde
approved these changes
Apr 18, 2024
treefmt fails |
Haskell has various formatters and no standard one. While I originally wanted to use ormolu, we agreed to switch to fourmolu because we weren't super happy about some decisions in ormolu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that all Nix files are formatted with
pkgs.nixfmt-rfc-style
(not the local version to avoid having to build the package for the dev environment!) and Haskell files are formatted with fourmolu with some reasonable configuration.