Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release preparations #131

Closed
wants to merge 1 commit into from
Closed

Release preparations #131

wants to merge 1 commit into from

Conversation

piegamesde
Copy link
Member

I'd like to go the path towards making a new release. What are the necessary steps involved apart from checking the change log and bumping the version?

@yorickvP yorickvP requested a review from Lucus16 September 7, 2023 15:23
@yorickvP
Copy link
Contributor

@Lucus16 bump. I believe there's some hackage involved.

@Lucus16
Copy link
Contributor

Lucus16 commented Sep 18, 2023

@Lucus16
Copy link
Contributor

Lucus16 commented Sep 18, 2023

@gromakovsky We can't access buildkite and it doesn't seem to be working. Can you see what's up?

@gromakovsky
Copy link

As far as I know, our Buildkite setup doesn't work with PRs from forks and it's not easy to fix.
@piegamesde since I previously granted you write access to this repo, could you please push your branch directly to this repo (not your fork) and open a PR from there? It should work then.

@piegamesde
Copy link
Member Author

#132

@piegamesde piegamesde closed this Sep 23, 2023
@piegamesde
Copy link
Member Author

As far as I know, our Buildkite setup doesn't work with PRs from forks and it's not easy to fix.

Does this mean that the CI doesn't work at all for external contributions?

@Lucus16
Copy link
Contributor

Lucus16 commented Sep 23, 2023

Does this mean that the CI doesn't work at all for external contributions?

IIRC, this is to prevent running untrusted code on serokell machines since buildkite runs builds on your own agents. Once you've checked a commit is not evil, you can push the same commit to a branch on this repo and buildkite will pick it up and I think even report on it in the original PR.

@gromakovsky
Copy link

We are slowly moving our repos to use GitHub Actions CI instead of Buildkite, which should support running CI from forks (when someone explicitly approves that). We can migrate this repo too, but I'm not sure if it's a good idea, because our GA setup uses our own infra, which won't be available after this repo is transferred elsewhere. Though, it may work just fine after the transfer, because it shouldn't require much besides nix 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants