Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilise nix nar subcommands #8980

Closed
wants to merge 1 commit into from
Closed

Stabilise nix nar subcommands #8980

wants to merge 1 commit into from

Conversation

vicky1999
Copy link
Contributor

Motivation

  • Renamed the command nar dump-path to nar pack

Context

This change is required in #8875

Changes made:

  • Renamed dump-path.cc to pack.cc
  • Renamed nar-dump-path.md to nar-pack.md

Screenshot

image

Priorities

Add 👍 to pull requests you find important.

@github-actions github-actions bot added documentation new-cli Relating to the "nix" command labels Sep 14, 2023
@vicky1999 vicky1999 changed the title Renamed nar dump-path to nar pack Stabilise nix nar subcommands Sep 14, 2023
@edolstra
Copy link
Member

Can you add a backwards compatibility alias in NixArgs::NixArgs() in src/nix/main.cc?

We should probably also rename nix store dump-path at the same time.

@vicky1999
Copy link
Contributor Author

Sure, I am working on that as part of #8914

@vicky1999
Copy link
Contributor Author

@edolstra I tried to implement aliasing in main.cc. But, when trying to build the project and run with nix-shell, I am getting this error:
image

I haven't faced this error before and this issue arised after taking the latest changes in master. Kindly please let me know if I am doing something wrong.

@fricklerhandwerk
Copy link
Contributor

I'm confused by this.

  1. Why do you start nix-shell with sudo? This should never be necessary, even on WSL.

  2. Where does the import <nixpkgs> come from? The shell takes its inputs from flake.nix where they are all pinned.

Please refer to the reference manual for building Nix. Seek help for such troubleshooting on the community platforms (Discourse, Matrix), providing exact steps for reproducing your problem.

Unfortunately it's impractical for maintainers to assist with this kind of debugging in full detail, as that would eat into the time for our prioritised activities, which is already very little compared to the number of open issues and PRs. Doing this in-band would also flood the PR timeline with immaterial discussion, making it harder to keep track of for everyone.

Don't get discouraged though. We're very happy that you're taking the time to help out and will guide you to get your work in if you stick at it.

@vicky1999 vicky1999 closed this by deleting the head repository Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation new-cli Relating to the "nix" command
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants