-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document "Import From Derivation" #7332
Document "Import From Derivation" #7332
Conversation
IMHO a glossary is not the right place for this kind of documentation. A glossary is a dictionary-like list of short descriptions, which can of course link to more extensive docs elsewhere. "Importing from a derivation" should probably be its own section in the Nix language chapter. |
1759abd
to
8134da1
Compare
Also, I think it is high time that we stop calling it "import from derivation"
I would therefore call the section "reading build results", and just mention within the "import from derivation" term as something people do say that is misleading. |
Also I still don't like "realise": it is an English word without meaning, pure nonsense jargon. I think "built" is fine; even if we didn't do the building someone else did. Passive language can help here
|
@Ericson2314 @edolstra I agree, but renaming the concept makes this change much harder: we already have a configuration option I closed all the comments regarding the term itself.
I avoided making explicit note of the historicity of the term, and focused on explaining the concept behind it instead. My request to reviewers is to check that the conceptual description is correct.
This part already accounts for that fact.
I closed all the comments related to #7318 and #7320. Let us discuss those in isolation, please. |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/tweag-nix-dev-update-40/23480/1 |
cbed610
to
fbf0e5b
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2022-12-19-nix-team-meeting-minutes-18/24121/1 |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2023-06-05-documentation-team-meeting-notes-52/28937/1 |
56b77d6
to
8b18c67
Compare
I know we discussed renaming IFD (proposal: Read From Realisation), but let's first agree on the documentation. |
Co-authored-by: Robert Hensing <[email protected]>
Co-authored-by: Robert Hensing <[email protected]>
Co-authored-by: Robert Hensing <[email protected]>
Co-authored-by: Robert Hensing <[email protected]>
Co-authored-by: Robert Hensing <[email protected]>
c493b4b
to
b755328
Compare
This should be ready to merge. |
output path is not really a thing, since it's really just the store path to a derivation output.
Addressed all comments. Let's fix forward from here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Here's some small things I noticed
The term "Import From Derivation" is historic and does not represent the concept well.
This change does not address the adequacy of term, and only explains the concept. Reviewers: Please assess the correctness and completeness of the description and how easy it is to understand.
Renaming can be done in a follow-up PR.
This work is sponsored by Antithesis ✨
Related: #8450 (but won't fix here)