Skip tests on systems with restricted usernamespaces #12051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
with-tests
|
|
Mic92
force-pushed
the
ci-follow-up
branch
4 times, most recently
from
7613dd4 to
6642863
Compare
Mic92
force-pushed
the
ci-follow-up
branch
2 times, most recently
from
00e32c1 to
3b69081
Compare
|
🎉 All dependencies have been resolved ! |
roberth
approved these changes
Dec 15, 2024
…r namespaces Update tests/functional/common/functions.sh Co-authored-by: Robert Hensing <[email protected]>
edolstra
previously requested changes
Dec 16, 2024
| @@ -345,4 +345,15 @@ count() { | |||
|
|
|||
| trap onError ERR | |||
|
|
|||
| requiresUnprivilegedUserNamespaces() { | |||
| if [[ -f /proc/sys/kernel/apparmor_restrict_unprivileged_userns ]] && [[ $(< /proc/sys/kernel/apparmor_restrict_unprivileged_userns) -eq 1 ]]; then | |||
There was a problem hiding this comment.
This test should also be added to userNamespacesSupported() in src/libutil/linux/namespaces.cc. In fact, if we check for it in Nix itself, then maybe the tests will succeed even if unprivileged user namespaces are restricted.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/2024-12-16-nix-team-meeting-minutes-203/57483/1 |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #12050
This makes ci pass: https://github.com/NixOS/nix/actions/runs/12329995455/job/34414955507?pr=12051
even on systems that have restricted usernamespaces: 6642863