Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert: Make $HOME=/proc/homeless-shelter instead of /homeless-shelter #11366

Merged
merged 2 commits into from
Aug 25, 2024

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Aug 25, 2024

Motivation

Since /proc/homeless-shelter returns a different errno than /homeless-shelter (ENOENT vs EACCES), we need to revert this change. Software depends on this error code i.e. cargo and therefore breaks.

Context

#11300

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

Mic92 added 2 commits August 25, 2024 09:08
…-to-proc"

This reverts commit 43e82c9, reversing
changes made to d79b9bd.

Since /proc/homeless-shelter returns a different errno than /homeless-shelter (ENOENT vs EACCES), we need to revert this change.
Software depends on this error code i.e. cargo and therefore breaks.
…-to-proc-changelog"

This reverts commit fa49d2e, reversing
changes made to af26fe3.
@Mic92 Mic92 changed the title Homeless shelter Revert homeless shelter Aug 25, 2024
@Mic92 Mic92 changed the title Revert homeless shelter Revert: Make $HOME=/proc/homeless-shelter instead of /homeless-shelter Aug 25, 2024
@Mic92 Mic92 requested a review from tomberek August 25, 2024 07:14
@tomberek tomberek merged commit a30eb6d into NixOS:master Aug 25, 2024
13 checks passed
@Mic92 Mic92 deleted the homeless-shelter branch August 25, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants