Skip to content

Commit

Permalink
Fix rust toolchain version and review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
sosthene-nitrokey committed May 24, 2023
1 parent 4ce0ca6 commit 74d76d7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ edition = "2021"
description = "OpenPGP smart card implementation"
repository = "https://github.com/nitrokey/opcard-rs"
license = "LGPL-3.0-only"
rust-version = "1.63.0" # see MSRV section in readme
rust-version = "1.66.0" # see MSRV section in readme

[workspace]
members = [
Expand Down
7 changes: 5 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,19 +77,22 @@ Plug your Nitrokey 3 and use [nitropy](https://docs.nitrokey.com/software/nitrop
- libpcsclite
- nettle
- pkg-config
- Rust toolchain

To run the tests, you also need these tools:
- gnupg
- scdaemon
- vsmartcard (vpcd)

See the [CI Dockerfile](./ci/Dockerfile) for all steps to set up the build environment on Debian-based distributions.
See the [CI Dockerfile](./ci/Dockerfile) for all steps to set up the development environment on Debian-based distributions.

For a complete usb token firmware implementation including Opcard for OpenPGP support, see the [Nitrokey 3 firmware repository](https://github.com/Nitrokey/nitrokey-3-firmware).

## Minimum Supported Rust Version (MSRV)

The minimum supported Rust version (MSRV) for this crate is the most recent stable Rust release.
Older versions may or may not work.
Rust versions older than 1.63.0 cannot be used to build this crate.
Rust versions older than 1.66.0 cannot be used to build this crate.

## Bug reports

Expand Down

0 comments on commit 74d76d7

Please sign in to comment.