Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update littlefs2 to v0.5.0 #525

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Update littlefs2 to v0.5.0 #525

merged 1 commit into from
Oct 25, 2024

Conversation

@robin-nitrokey robin-nitrokey force-pushed the deps branch 2 times, most recently from b2e3dd1 to 16d54c6 Compare August 13, 2024 17:58
@nitrokey-ci
Copy link
Collaborator

nitrokey-ci commented Aug 13, 2024

No significant changes.

Insignifcant changes
metric value change
binary-size-nk3am 1,366,906 -8,476 (-0.62%)
binary-size-nk3am-test 1,878,038 -11,086 (-0.59%)
binary-size-nk3xn 491,888 -2,640 (-0.53%)
binary-size-nk3xn-test 539,152 -1,960 (-0.36%)
binary-size-nkpk 709,547 -6,133 (-0.86%)

@robin-nitrokey robin-nitrokey force-pushed the deps branch 2 times, most recently from c46d908 to 4035f94 Compare September 19, 2024 18:57
@robin-nitrokey robin-nitrokey force-pushed the deps branch 2 times, most recently from 9a3afe7 to fc6c1ea Compare October 14, 2024 19:08
@robin-nitrokey robin-nitrokey changed the title Update dependencies Update littlefs2 to v0.5.0 Oct 24, 2024
@robin-nitrokey robin-nitrokey marked this pull request as ready for review October 24, 2024 19:26
@robin-nitrokey
Copy link
Member Author

With this PR, trussed is the only crate outside of this repository that depends directly on littlefs2. (admin-app depends on littlefs2, but only for the migration-tests feature. Even the re-exports by trussed are not used by other crates.)

@sosthene-nitrokey
Copy link
Collaborator

And some binary size benefits too!. That was expected?

@robin-nitrokey
Copy link
Member Author

The refactoring itself leads to a small increase in binary size because it removes the infallible conversions from strings and byte slices. But that is more than compensated by this little change.

@robin-nitrokey robin-nitrokey merged commit 53f8d89 into main Oct 25, 2024
9 checks passed
@robin-nitrokey robin-nitrokey deleted the deps branch October 25, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants