Offer to stop a G7 in engineering mode only #3319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an example of a post that worries me about xDrip offering to stop a G7.
|
jamorham
reviewed
Feb 7, 2024
| @@ -101,8 +103,10 @@ public NavDrawerBuilder(final Context context) { | |||
| } | |||
| } | |||
| } | |||
| this.nav_drawer_options.add(context.getString(R.string.stop_sensor)); | |||
| this.nav_drawer_intents.add(new Intent(context, StopSensor.class)); | |||
| if (getBestCollectorHardwareName() != "G7" || Pref.getBooleanDefaultFalse("engineering_mode")) { // If we are using G7, offer the stop sensor option in engineering mode only | |||
There was a problem hiding this comment.
You should use equals() for string comparisons as otherwise it is comparing the object reference rather than the content.
There was a problem hiding this comment.
Thanks for the guidance.
Done
|
Tested again after correcting the syntax. |
jamorham
approved these changes
Feb 15, 2024
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have already started to see posts of people asking for help who have stopped a G7.
Under normal circumstances, there is no reason to ever stop a G7.
This PR will not show the stop option in the main menu if we are using a G7 unless engineering mode is enabled.
I have tested this with a G7 and verified that enabling engineering mode shows the stop option and disabling engineering mode removes the stop option.
I have tested it with a G6 and confirmed that the stop sensor option is available regardless of engineering mode.