Correct warmup time even before firmware is known #3318
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did not connect in time. I will try to test again in 10 days. |
Der-Schubi
added a commit
to Der-Schubi/xDrip
that referenced
this pull request
Feb 8, 2024
…n#3318 Merge remote-tracking branch 'Navid200/Navid_2024_01_26' into schubi
|
Looks good: |
|
I can confirm, works fine! |
|
Redundant! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I relied on firmware, in this PR #3195, to show the correct warmup time for a G7.
Today, I noticed that it still showed 2 hours for warmup right after connecting to G7.
After one more read cycle, it showed the correct value.
I suspect the reason is that Firmware is not known right away after connectivity.
This PR changes the condition to rely on what the user has chosen instead of relying on the firmware.
I will be testing this in 10 days.