Add Afrezza, Apidra, Levemir, Basaglar and Tresiba profiles #3157
Conversation
…ect Lantus, Toujeo and Novo Rapid profiles based on more recent data. (#3) Add Afrezza, Apidra, Levemir, Basaglar and Tresiba profiles, and correct Lantus, Toujeo and Novo Rapid profiles based on more recent data. This is NightscoutFoundation#1388 with the merge conflicts resolved.
|
I read #1388 and felt compelled to comment. I fully use the Insulin Profiles and have been since they were first released in nightlies. I use Novolog (Novorapid) and Tresiba. In the Insulin Profile I use Novorapid and Toujeo because Tresiba is not a choice. Needless to say I have to do a lot of calculations in my head! Can xdrip (or any other software) predict things like exercise, sickness, or any of the things we must consider when calculating a bolus? Of course not. Xdrip is not an artificial pancreas. But xdrip has been helping me for almost 20 of my 52 years of diabetes. Without it I doubt if I could maintain a normal a1C. Please merge this PR and make xdrip better, not perfect. |
|
I absolutely agree! |
|
Same.
Glen
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: ANDREAPIPPI ***@***.***>
Sent: Tuesday, October 31, 2023 10:51:25 AM
To: NightscoutFoundation/xDrip ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [NightscoutFoundation/xDrip] Add Afrezza, Apidra, Levemir, Basaglar and Tresiba profiles, and correct Lantus, Toujeo and Novo Rapid profiles based on more recent data. (PR #3157)
I absolutely agree!
Andrea
—
Reply to this email directly, view it on GitHub<#3157 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AWTM6772OSJZCLJZ6U464ADYCEUA3AVCNFSM6AAAAAA6RZGXKWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBXGYYDKMRRGM>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
|
If this PR were just additive in terms of insulin profiles I would be very happy to merge it. My concern is the changes to existing profiles which could impact existing users unexpectedly. Can you please explain the changes where this has been done? |
|
I just took the changes from #1388 and resolved the merge conflicts - I think everything regarding these changes and the sources for the changs in the profiles has already been discussed there. I'm perfectly happy to remove the changes to existing insulin profiles if that will get this finally merged. #1388 has been open for over 3 years, intensely discussed and approved, yet nothing happened - so I decided to take matters into my own hands. After all, #wearenotwaiting - and as an Apidra user, I want to be able to choose the insulin I use in xDrip+. |
TheConen
changed the title
|
[jamorham] I'm a little confused. |
|
Okay. I'm just asking for explanation of the changes to existing profiles as that is not present in this PR yet. Personally I have never seen what I think of as an accurate insulin action curve and the information from manufacturers doesn't seem to reflect any reality and I expect things differ for different people but I understand that this is a useful feature to people even so and am happy to help people improve it. The issue here is that if a user is using a particular action curve and then this PR changes it then that user might see different results without realizing that the curve has been changed. @ANDREAPIPPI says that these changes are not so significant but that is exactly the sort of information I'm asking for in relation to this PR before we make a change that impacts existing users it needs to be handled carefully. I would like to merge the PR but there needs to be justification in it. It isn't enough to reference previously submitted PRs, please state exactly what this PR does and the reasons for the change and where there are changes to existing behavior how that is expected to impact on users. This isn't a feature I use and so I'm not so familiar with what could go wrong with these changes. |
|
TheConen, could you please show us a comparison of the old/new action curves of Novorapid, Lantus and Toujeo that you proposed in your first post? |
|
I removed all changes to existing insulin profiles so that this PR now only adds new insulin profiles.
It adds new insulin profiles for Afrezza, Apidra, Levemir, Basaglar and Tresiba
because as a user of one of these insulins (Apidra) I want to be able to choose that Insulin when entering treatments in xDrip+
Users have more insulin types to choose from.
This PR shouldn't even exist. The only reason this PR exists is because #1388 has been abandoned. All your questions have already been answered in #1388 by @jordy-de-koning, including scientific sources and manufacturer information regarding the data for the insulin profiles right in the very first post. Feel free to delete this PR and merge #1388 instead - but do merge one of them. |
|
@jamorham I can vouch for a real world effect of the lack of this PR. |
|
Thanks for this, please feel free to re-add the the insulin types which had modifications. Those modifications just need to be justified in terms of their impact to existing users so that we can be sure as we can be that it wont cause problems. Overall I have some ideas for how this feature could be improved. The structure of how this works is not ideal in terms of flexibility and user choice and I would have preferred to have had it implemented initially in a different way. Please see https://github.com/NightscoutFoundation/xDrip/blob/master/CONTRIBUTING.md#contributing-patches-to-xdrip to understand the sort of things that will be evaluated when reviewing a PR. |
|
After this PR has been merged, this is what you see on a screen resolution of 2160 x 1080, and there is no way to scroll down to see Fiasp.
|
|
I don't know. I just downloaded the one in the nightlies |
|
I'm not sure what happened to the other "missing" insulin profiles. Lyumjev [ultra-rapid lispro (URLi)] was mentioned a while back but is still on the waiting list. Can it be included? (I could digitise the plots if that helps). PDF of profile info extracted from manufacturer's data as linked below: Link to manufacturer's data (see section 12 "Clinical Pharmacology": |
|
Lyumjev is not one of the insulins that was in #1388, hence why it was not in this PR. I'm happy to open a new PR for Lyumjev if needed. |
|
Thanks for your reply. The original request was issue #1561 from Frediabetics. This was closed when Lyumjev was added to a table of requested profiles in #1898 which is still open. There was an issue concerning the validity of the profile data source. I'm sorry if I've "hijacked" this PR. |
This is #1388 with the merge conflicts resolved.
Since #1388 seems to be dead, I resolved the merge conflicts and created this PR.