Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: publish nibiru-ownable, resolve linter errors, and add GH automation #151

Merged
merged 6 commits into from
Sep 24, 2024

Conversation

Unique-Divine
Copy link
Member

@Unique-Divine Unique-Divine commented Sep 24, 2024

  • chore: publish nibiru-ownable and nibiru-ownable-derive
  • fix(warning): deprecated clippy warning for CosmosMsg::Stargate
  • chore: linter, fix 'just tidy'
  • chore(github): Add project automation for https://tinyurl.com/25uty9w5
  • chore(contracts): add local copy of cw3-fixed-multisig that compiles on v2

Summary by CodeRabbit

Release Notes

  • New Features

    • Automated labeling of newly opened issues with "S-triage" for better issue management.
    • Introduced a workflow for automating the addition of issues to a project board and applying labels.
  • Documentation

    • Added a comprehensive README.md for the CW3 Fixed Multisig contract, detailing its functionality and usage.
  • Updates

    • Updated package dependencies and configurations across various components for improved stability and performance.
  • Bug Fixes

    • Enhanced error handling in the smart contract to provide clearer debugging information.

Copy link
Contributor

coderabbitai bot commented Sep 24, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request introduces multiple changes across various files, including the addition of a new issue label configuration that automatically labels new issues for triage, a new GitHub workflow for managing issues, and modifications to several Rust package configurations and implementations. Key updates include restructuring dependencies in Cargo.toml files, introducing new contract functionalities for a multisignature governance model, and implementing error handling and state management for the new contract.

Changes

File Change Summary
.github/issue-labeler-config.yml Added "S-triage" label for all new issues.
.github/workflows/gh-issues.yml New workflow for automating issue management, adding issues to a project board and labeling them.
Cargo.toml (various) Updated dependencies, including renaming ownable-derive to nibiru-ownable-derive.
contracts/core-cw3-fixed-msig/*.rs Introduced a multisignature governance contract with functions for instantiation, execution, and querying.
contracts/core-cw3-fixed-msig/Cargo.toml New package declaration for cw3-fixed-multisig, including dependencies and metadata.
packages/nibiru-ownable/Cargo.toml Renamed dependency from ownable-derive to nibiru-ownable-derive and added license declaration.
packages/nibiru-ownable/src/address_like.rs Introduced AddressLike trait for address representation.
packages/nibiru-ownable/src/lib.rs Added address_like module and updated imports for derived macros.

Possibly related PRs

🐰 Hopping through the code, oh what a sight,
New labels and workflows make everything bright!
A multisig contract, so clever and neat,
With traits and dependencies, it's quite the feat!
Let's celebrate these changes, so fresh and so bold,
In the world of code, new stories unfold! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 89.71229% with 118 lines in your changes missing coverage. Please review.

Project coverage is 88.01%. Comparing base (902b788) to head (2ddfecf).
Report is 35 commits behind head on main.

Files with missing lines Patch % Lines
contracts/core-cw3-fixed-msig/src/contract.rs 88.91% 110 Missing ⚠️
contracts/core-cw3-fixed-msig/src/bin/schema.rs 0.00% 7 Missing ⚠️
contracts/core-cw3-fixed-msig/src/msg.rs 75.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
contracts/broker-staking/src/contract.rs 83.44% <100.00%> (ø)
contracts/broker-staking/src/testing.rs 95.41% <ø> (ø)
contracts/core-cw3-fixed-msig/src/error.rs 100.00% <100.00%> (ø)
...racts/core-cw3-fixed-msig/src/integration_tests.rs 100.00% <100.00%> (ø)
contracts/core-cw3-fixed-msig/src/state.rs 100.00% <100.00%> (ø)
nibiru-std/src/proto/traits.rs 76.78% <ø> (ø)
packages/nibiru-ownable-derive/src/lib.rs 0.00% <ø> (ø)
packages/nibiru-ownable/src/lib.rs 96.88% <ø> (ø)
contracts/core-cw3-fixed-msig/src/msg.rs 75.00% <75.00%> (ø)
contracts/core-cw3-fixed-msig/src/bin/schema.rs 0.00% <0.00%> (ø)
... and 1 more

... and 40 files with indirect coverage changes

@Unique-Divine Unique-Divine merged commit e049b12 into main Sep 24, 2024
5 checks passed
@Unique-Divine Unique-Divine deleted the ud/ownable branch September 24, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant