Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor network모듈의 datastore에 대한 의존성 제거 #62

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Refactor network모듈의 datastore에 대한 의존성 제거 #62

merged 2 commits into from
Sep 26, 2024

Conversation

eshc123
Copy link
Member

@eshc123 eshc123 commented Sep 26, 2024

주요 내용

  1. core:network 모듈에 TokenProvider interpace를 추가하였습니다.
  2. core:data:auth 모듈에서 TokenProvider 를 구현하는 구현체 AuthTokenProvider를 만들고, AuthDataModule에서 의존성 주입을 설정합니다.
  3. core:network에서 core:datastore에 대한 의존성을 제거하고 TokenProvider를 통해 토큰 관련 로직을 실행하도록 하였습니다.

@eshc123 eshc123 requested a review from bywindow September 26, 2024 03:19
@eshc123 eshc123 self-assigned this Sep 26, 2024
bywindow
bywindow approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@bywindow bywindow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오오!! 굳!!!

@eshc123 eshc123 merged commit 441fba7 into dev Sep 26, 2024
1 check passed
@eshc123 eshc123 deleted the refactor/data-layer branch September 26, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bywindow bywindow bywindow approved these changes

Assignees

@eshc123 eshc123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eshc123 @bywindow