네비게이션바 구현 #21
Merged
네비게이션바 구현 #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
bywindow
commented
Aug 7, 2024
bywindow
commented
- TopBar 구현
- 온보딩, 미션생성, 초대코드 입력 화면에 TopBar 추가
- 다크모드일 때 statusbar 텍스트가 보이지 않던 버그 수정
eshc123
approved these changes
Aug 8, 2024
| leftActionButtons: @Composable (() -> Unit)? = null, | ||
| rightActionButtons: @Composable () -> Unit = {}, | ||
| ) { | ||
| CompositionLocalProvider(LocalContentColor provides contentColor) { |
There was a problem hiding this comment.
나는 아직 CompositionLocal을 많이 안 써봐서 잘 몰라서 물어보는건데..! 혹시 CompositionLocal을 사용한 이유가 어떻게 될까?
There was a problem hiding this comment.
나도 이번에 새롭게 알게 됐는데 CompositionLocalProvider 사용하면 이 안에 있는 컴포넌트는 모두 provider하는 특성을 유지한다고 하더라고! 그래서 네비게이션 같은 곳에서 백그라운드 컬러 줄 떄 사용되는 것 같아!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.