Feature/implement onboarding UI #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bywindow
reviewed
Aug 1, 2024
There was a problem hiding this comment.
이거 뒷 배경에 자신의 캐릭터를 넣는 것 같은데 전체를 png로 가지고 있으면 안되지 않을까...?
캐릭터 이미지 에셋을 core-designsystem 쪽에 넣는 작업을 지금 하고 있는데 그 pr 뒤에 다시 수정하는 건 어때?
There was a problem hiding this comment.
오 맞는것 같아! 그럼 지금 파일은 지우고 배경만 받아두었다가 에셋 PR 머지되면 받아서 수정하고 다시 푸시할게!
eshc123
force-pushed
the
feature/implement-onboarding-ui
branch
from
542661a to
2115f94
Compare
bywindow
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
주요 내용
참고
링크