Skip to content

Commit

Permalink
[istio-endpoints] Bugfix on the Sidecar object (#16)
Browse files Browse the repository at this point in the history
```
admission webhook "validation.istio.io" denied the request: configuration is invalid: host must be of form namespace/dnsName
```

The namespace needs to be included (or `.`).
  • Loading branch information
diranged authored Jun 3, 2021
1 parent e484e03 commit 9c3784e
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion charts/istio-endpoints/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: istio-endpoints
description: Per-Namespace Istio Configuration Chart
type: application
version: 0.1.1
version: 0.1.2
appVersion: latest
maintainers:
- name: diranged
Expand Down
4 changes: 2 additions & 2 deletions charts/istio-endpoints/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Per-Namespace Istio Configuration Chart

![Version: 0.1.1](https://img.shields.io/badge/Version-0.1.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: latest](https://img.shields.io/badge/AppVersion-latest-informational?style=flat-square)
![Version: 0.1.2](https://img.shields.io/badge/Version-0.1.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: latest](https://img.shields.io/badge/AppVersion-latest-informational?style=flat-square)

[elasticache]: https://aws.amazon.com/elasticache/
[serviceentry]: https://istio.io/latest/docs/reference/config/networking/service-entry/
Expand Down Expand Up @@ -53,7 +53,7 @@ spec:
+ dependencies:
+ - name: istio-endpoints
+ repository: https://k8s-charts.nextdoor.com
+ version: 0.1.1
+ version: 0.1.2
maintainers:
- name: diranged
email: [email protected]
Expand Down
2 changes: 1 addition & 1 deletion charts/istio-endpoints/templates/sidecar.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ spec:
the Service Entry.
*/}}
hosts:
- {{ $name }}.{{ include "istio-endpoints.domainName" $global }}
- ./{{ $name }}.{{ include "istio-endpoints.domainName" $global }}

{{- /*
Setting captureMode to NONE is how you tell Istio that it's not doing any
Expand Down

0 comments on commit 9c3784e

Please sign in to comment.