-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deployment #20
base: main
Are you sure you want to change the base?
Fix deployment #20
Conversation
docs/make.jl
Outdated
clean = true, doctest = false, linkcheck = false, | ||
warnonly = [:docs_block, :missing_docs], | ||
format = Documenter.HTML(assets = ["assets/favicon.ico"]), | ||
#canonical = "https://docs.sciml.ai/LinearSolve/stable/"), | ||
pages = pages) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this turned off?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was giving an error on a couple of paper links, I only changed it to test for now, eventually it should be switched back.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you just white list the bad links?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, will check them again when we sort out the workflow and if need be will add them to linkcheck_ignore
.
Someone probably needs to take the time to refresh the keys and generate a non-documenter specific one. But I show here then what's required as the other changes. |
Thanks Chris, will tackle this again from tomorrow. |
No description provided.