Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deployment #20

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Fix deployment #20

wants to merge 12 commits into from

Conversation

harisorgn
Copy link
Member

No description provided.

docs/make.jl Outdated Show resolved Hide resolved
docs/make.jl Outdated
Comment on lines 11 to 14
clean = true, doctest = false, linkcheck = false,
warnonly = [:docs_block, :missing_docs],
format = Documenter.HTML(assets = ["assets/favicon.ico"]),
#canonical = "https://docs.sciml.ai/LinearSolve/stable/"),
pages = pages)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this turned off?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was giving an error on a couple of paper links, I only changed it to test for now, eventually it should be switched back.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you just white list the bad links?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, will check them again when we sort out the workflow and if need be will add them to linkcheck_ignore.

@ChrisRackauckas
Copy link
Member

Someone probably needs to take the time to refresh the keys and generate a non-documenter specific one. But I show here then what's required as the other changes.

@harisorgn
Copy link
Member Author

Someone probably needs to take the time to refresh the keys and generate a non-documenter specific one. But I show here then what's required as the other changes.

Thanks Chris, will tackle this again from tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants