Adding ability to save simulations to the agent learning loop #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like it's working, but the values aren't making a ton of sense yet
@anandpathak31 @harisorgn this version now works with MTK9. Would be good to confirm that it is also getting the correct solution. I notice that it's not using `run_experiment!` though, so the way I implemented hooks won't work with that. Is there a reason it avoids the `run_experiment!` and uses a custom loop instead?
Spinning this off into separate utility functions per discussion with Haris, so will not merge with this PR.
|
Merging and closing #376 once checks have finished - save functionality and MTK compatibility issues are all fixed. Will add voltage extraction/averaging utilities in new PR. |
Not including test in `runtests.jl` but structured so can be included. Omitted because it will save out data files and that's not wanted for now.
Switch from saving jld2 files to csv files for output dataframes.
|
Closes #376 |
This was referenced Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension to solve #376. Saving is fine, just need to add accessing functions and some additional helpers now.