Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checkout cancel URL which should not be included for integration type embedded checkout #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ctsrc
Copy link

@ctsrc ctsrc commented Jul 29, 2021

With the checkout cancel URL set, embedded checkout fails as described in issue #11.

This change fixes the problem described in said issue.

…on type embedded checkout

With the checkout cancel URL set, embedded checkout fails as described in issue #11.

This change fixes the problem described in said issue.
@ctsrc
Copy link
Author

ctsrc commented Jul 30, 2021

Please note that there appears to be other issues with the embedded checkout in MiaSample as well, but those are orthogonal to the problem being dealt with here.

However, in order for the fix here to be visible/relevant, you need to have the "handling of consumer data" setting set to either "injected by merchant" or "no shipping address". There appears to be a separate problem that makes it so that having "handling of consumer data" set to "none" causes a 401 response with content-length 0 (so no details about what the problem is in that case) on embedded checkout. But I haven't looked into that problem because at the moment we are looking at using the "no shipping address" setting as this is the one that fits our own integration.

Anyhow, mentioning this so that when you look at merging this PR you take this fact into account.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant