Merge pull request #1109 from shift8nix/issue_1038

fix issue 1038
Netflix · Sep 19, 2018 · 00ff52a · 00ff52a
2 parents 0bd65d6 + 4cf6c7d
commit 00ff52a
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/security_monkey/auditors/gcp/gce/firewall.py b/security_monkey/auditors/gcp/gce/firewall.py
@@ -47,15 +47,16 @@ def _port_range_exists(self, allowed_list, error_cat='ALLOWED'):
         Check to see if a port range exists in the allowed field.
         """
         errors = []
-        for allowed in allowed_list:
-            ports = allowed.get('ports', None)
-            if ports:
-                for port in ports:
-                    if str(port).find('-') > -1:
-                        ae = make_audit_issue(
-                            error_cat, 'EXISTS', 'PORTRANGE')
-                        ae.notes = '%s:%s' % (allowed['IPProtocol'], port)
-                        errors.append(ae)
+        if allowed_list:
+            for allowed in allowed_list:
+                ports = allowed.get('ports', None)
+                if ports:
+                    for port in ports:
+                        if str(port).find('-') > -1:
+                            ae = make_audit_issue(
+                                error_cat, 'EXISTS', 'PORTRANGE')
+                            ae.notes = '%s:%s' % (allowed['IPProtocol'], port)
+                            errors.append(ae)
         return errors
 
     def _target_tags_valid(self, target_tags, error_cat='TARGET_TAGS'):