Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for https streams #96

Open
wants to merge 3 commits into
base: 2.x
Choose a base branch
from
Open

Conversation

johanhaleby
Copy link
Contributor

This commit adds support for HTTPS (SSL) streams. However it will not work until my other pull request for RxNetty has been merged. Once that pull request has been merged a new version of RxNetty must be released and we should upgrade the RxNetty version of Turbine.

@johanhaleby
Copy link
Contributor Author

This also fixes issue 87 (at least for the Turbine 2.x branch).

@johanhaleby
Copy link
Contributor Author

The RxNetty pull request has now been accepted and it should be available in version 0.4.11.

@johanhaleby
Copy link
Contributor Author

RxNetty 0.4.11 has been released so I've updated the pull request. I've verified that SSE + SSL works with my fixes in 0.4.11.

@SagarPune
Copy link

SagarPune commented Jul 27, 2016

Hi,
We are trying to enable https in turbine stream. And we are facing below problem:


ERROR 10644 --- [o-eventloop-3-1] r.n.p.h.s.ServerRequestResponseConverter : Invalid HTTP request recieved. Decoder error.

java.lang.IllegalArgumentException: invalid version format: ■\ᅦ:4'|"￀+￀/￀,￀0ᅩ로또ᅩ￀     ￀￀
        at io.netty.handler.codec.http.HttpVersion.<init>(HttpVersion.java:130) ~[netty-codec-http-4.0.27.Final.jar!/:4.0.27.Final]
        at io.netty.handler.codec.http.HttpVersion.valueOf(HttpVersion.java:84) ~[netty-codec-http-4.0.27.Final.jar!/:4.0.27.Final]


Please provide any suggestion
Thank you.

@johanhaleby
Copy link
Contributor Author

johanhaleby commented Jul 28, 2016

You can try using my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants