Update to Stylelint 16 + restore removed rules #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 12, 2024 12:24
…s that were deprecated from stylelint v15 (see https://stylelint.io/migration-guide/to-15/)
quicoto
reviewed
Jun 13, 2024
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "@netcentric/stylelint-config", | |||
| "description": "Netcentric's coding and style rules for Stylelint", | |||
| "version": "2.0.1", | |||
| "version": "3.0.0", | |||
There was a problem hiding this comment.
Do not change the version here, please. This will be done automatically with CI
|
Generally the commits messages have a bad format and will not trigger a proper release if merged Please see https://github.com/Netcentric/stylelint-config/blob/main/docs/CONTRIBUTING.md regarding commit messages which add what they are. Also here, because this PR is a breaking change, it should be stated, so the version will be bumped to next major https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit-message-header |
|
Ah, I realised before and did a rebase, but did it wrong 😂 |
|
PR closed in favor of #19 with fixed commit messages |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 2 main things:
Of course this needs a whole major version change due to the breaking changes
Description
The decision of adding the @Stylistic package was based on the fact that these rules were already being used by the NC config. So for me it makes sense to keep them even if this deviates from the general approach that Stylelint has decided to keep.
Note that these rules were already lost in v2 of the NC rules, because after Stylelint v15 they had to be manually enabled again in the project, due to them being removed in the stylelint standard configuration.
The configuration has been tested with my own project, and is working as expected. There're a few new warnings being raised by the no-unsupported-browser-features plugin, so the Readme was updated with the newest recommendations
Related Issue
Fixes #17
Types of changes
Checklist: