Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KAW-7695 Add table block #12

Merged
merged 4 commits into from
Aug 7, 2024
Merged

KAW-7695 Add table block #12

merged 4 commits into from
Aug 7, 2024

Conversation

TomaszDziezykNetcentric
Copy link
Contributor

@TomaszDziezykNetcentric TomaszDziezykNetcentric commented Aug 6, 2024

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #KAW-7695

Test URLs:

Copy link

aem-code-sync bot commented Aug 6, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

Copy link

aem-code-sync bot commented Aug 6, 2024

Page Scores Audits Google
/tools/sidekick/blocks/table PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

blocks/table/table.css Outdated Show resolved Hide resolved
Copy link
Contributor

@lakshmishriaswathnarayana lakshmishriaswathnarayana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you have handle this component using table, can you also handle this as variant

@TomaszDziezykNetcentric
Copy link
Contributor Author

Since you have handle this component using table, can you also handle this as variant

done

@lakshmishriaswathnarayana lakshmishriaswathnarayana merged commit 80438d5 into main Aug 7, 2024
2 checks passed
@lakshmishriaswathnarayana lakshmishriaswathnarayana deleted the KAW-7695-table branch August 7, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants