-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
751 Expose isEmpty and isBlank for EL evaluation #752
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general, but:
- requires a minor version upgrade (please adjust the pom.xml accordingly)
- requires some info on documentation since when which method is supported.
there isn't much that speaks against linking these two methods, but we could also just document the |
Yeah, empty is a bit redundant, but since I was already exposing "isBlank" I decided to add its related method for consistency. |
@Positronic-Brain so I just checked and |
Sounds reasonable. Will do. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now. Thanks a lot.
This would implement issue #751