fix: singleton reinstantiated if registered at last & fix: initialized class attribute being overridden #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, I made these two corrections that you may be interested in.
singleton being reinstantiated if registered after its dependent
Right now, if we register a singleton dependency after registering it dependant, it will instanciate the singleton multiple
times.
With this change, I'm basically making the following test pass (it wouldn't pass with current release):
initialized class attribute being overridden
If we declare a class attribute and initialize it inside the class, rodi should not override it or even try to resolve it (IMO).
This is already being taken care of when the class attribute is annotated with
ClassVar
, but I think that the same logicshould apply if the attribute already has a value at resolving time, in other words, if the user already resolved it for us.