Stop singleton provider from recreating objects implementing __len__ #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're currently processing your upload. This comment will be updated when the results are available. |
|
Hi @Klavionik, |
|
@Klavionik your contribution is available with 2.0.4 - again Thank You for reporting and fixing this bug. |
|
Thank you for releasing it swifty! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Roberto! A tiny bugfix if you please.
Right now the singleton provider checks if the singleton instance already present using
if not self._instancecheck. This doesn't work well with objects implementing Sized protocol. Python calls__len__on such objects to check it for truthyness, and if the call returns 0, the condition evaluates toTrue- even if the instance was already created earlier.I fixed it simply to compare against
None.