Add more convenience methods for Arb/Acb types #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1703 +/- ##
==========================================
+ Coverage 84.72% 84.74% +0.01%
==========================================
Files 94 94
Lines 37469 37205 -264
==========================================
- Hits 31746 31529 -217
+ Misses 5723 5676 -47 ☔ View full report in Codecov by Sentry. |
... so that combining them with more instances of `Number` subtypes is accepted.
fingolfin
force-pushed
the
mh/arb-acb-compat
branch
from
4710638
to
acae614
Compare
|
To be clear: I don't expect anyone to read all of this in detail, but maybe check the gist of things... And we need more tests anyway.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... so that combining them with more instances of
Numbersubtypes is accepted.Unfortunately this is kind of an unending nightmare of things that are needlessly restricted, code duplication etc. So far I've not even touched the various acb/arb/complex/real matrix types.
Resolves #1652 (except for the discussion about
normalise, for which I opened a new issue at Nemocas/AbstractAlgebra.jl#1651)One issue with this kind of change is that it may cause method ambiguity errors. I already addressed some of those in here in a hopefully transparent manner.
Ideally this PR would add even more new test cases to cover all the new delegations, but I can't be bothered right now.