Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend ideal interface #1731

Merged
merged 10 commits into from
Aug 18, 2024
Merged

Extend ideal interface #1731

merged 10 commits into from
Aug 18, 2024

Commits on Jun 14, 2024

  1. Extend ideal interface

    paemurru committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    64bfd3b View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2024

  1. Update src/Ideal.jl

    Co-authored-by: Max Horn <[email protected]>
    paemurru and fingolfin authored Jun 18, 2024
    Configuration menu
    Copy the full SHA
    37bb59a View commit details
    Browse the repository at this point in the history
  2. Update according to comment by Max

    Before, it might have happened that the command `R * ZZRingElem(2)` fails while `R * big(2)` succeeds.
    paemurru committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    1724b1d View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. Apply suggestions from code review

    Max: "the advantage is that if some ring type wants to implement say ideal(R::MyRing, n::Int) in a special optimized fashion that avoids constructing R(n), then R*2 would benefit from that"
    
    Co-authored-by: Max Horn <[email protected]>
    paemurru and fingolfin authored Jun 19, 2024
    Configuration menu
    Copy the full SHA
    61459b6 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Use RingElem instead of Any

    Previously, there was a possibility of an infinite recursion if the base functions were not implemented. Also, writing `R(x)` when `x` is a vector is problematic, it might have unexpected results.
    paemurru committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    b97f932 View commit details
    Browse the repository at this point in the history
  2. Change API / base method

    paemurru committed Jul 31, 2024
    Configuration menu
    Copy the full SHA
    60922da View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2024

  1. Configuration menu
    Copy the full SHA
    18e5783 View commit details
    Browse the repository at this point in the history
  2. Update src/Ideal.jl

    fingolfin authored Aug 1, 2024
    Configuration menu
    Copy the full SHA
    9276a1b View commit details
    Browse the repository at this point in the history
  3. Allow ideal(R, x, y, z)

    This is already allowed for Hecke ideals.
    For consistency, we allow this already in AbstractAlgebra.
    paemurru committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    ddce90a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    980d758 View commit details
    Browse the repository at this point in the history