-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend ideal interface #1731
Merged
Merged
Extend ideal interface #1731
Commits on Jun 14, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 64bfd3b - Browse repository at this point
Copy the full SHA 64bfd3bView commit details
Commits on Jun 18, 2024
-
Co-authored-by: Max Horn <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 37bb59a - Browse repository at this point
Copy the full SHA 37bb59aView commit details -
Update according to comment by Max
Before, it might have happened that the command `R * ZZRingElem(2)` fails while `R * big(2)` succeeds.
Configuration menu - View commit details
-
Copy full SHA for 1724b1d - Browse repository at this point
Copy the full SHA 1724b1dView commit details
Commits on Jun 19, 2024
-
Apply suggestions from code review
Max: "the advantage is that if some ring type wants to implement say ideal(R::MyRing, n::Int) in a special optimized fashion that avoids constructing R(n), then R*2 would benefit from that" Co-authored-by: Max Horn <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 61459b6 - Browse repository at this point
Copy the full SHA 61459b6View commit details
Commits on Jul 31, 2024
-
Previously, there was a possibility of an infinite recursion if the base functions were not implemented. Also, writing `R(x)` when `x` is a vector is problematic, it might have unexpected results.
Configuration menu - View commit details
-
Copy full SHA for b97f932 - Browse repository at this point
Copy the full SHA b97f932View commit details -
Configuration menu - View commit details
-
Copy full SHA for 60922da - Browse repository at this point
Copy the full SHA 60922daView commit details
Commits on Aug 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 18e5783 - Browse repository at this point
Copy the full SHA 18e5783View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9276a1b - Browse repository at this point
Copy the full SHA 9276a1bView commit details -
This is already allowed for Hecke ideals. For consistency, we allow this already in AbstractAlgebra.
Configuration menu - View commit details
-
Copy full SHA for ddce90a - Browse repository at this point
Copy the full SHA ddce90aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 980d758 - Browse repository at this point
Copy the full SHA 980d758View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.