[core]: fix spotless linter #561
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jaguar0625
commented
Sep 5, 2024
Jaguar0625
commented
Jaguar0625
force-pushed
the
spotless/fix/core
branch
from
cb4c47c
to
24b08a9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #561 +/- ##
=========================================
Coverage 93.54% 93.54%
Complexity 6059 6059
=========================================
Files 718 718
Lines 17312 17312
Branches 1304 1304
=========================================
Hits 16195 16195
Misses 864 864
Partials 253 253
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Wayonb
approved these changes
Oct 9, 2024
| /** | ||
| * A Matrix implementation that uses CompRowMatrix from MTJ. | ||
| */ | ||
| /** A Matrix implementation that uses CompRowMatrix from MTJ. */ |
There was a problem hiding this comment.
Should we keep the docs as before?
/**
* A Matrix implementation that uses CompRowMatrix from MTJ.
*/
There was a problem hiding this comment.
i couldn't find a flag to tell spotless to prefer the multiline version
|
|
||
| /** | ||
| * Class for for retrieving mosaic supplies. | ||
| */ |
There was a problem hiding this comment.
I guess spotless needs to be run on the new files? so it should be a single line.
There was a problem hiding this comment.
this PR currently only has changes for core, but if rules look ok, i'll update it for the other projects as well
problem: spotless is not running
solution: update spotless configuration
add fixing of imports
Jaguar0625
force-pushed
the
spotless/fix/core
branch
from
24b08a9
to
cb5beae
Compare
|
Close and replace with #576 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.