Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View bug fix #21

Merged
merged 4 commits into from
Jan 4, 2021
Merged

View bug fix #21

merged 4 commits into from
Jan 4, 2021

Conversation

lorstenoplo
Copy link
Contributor

@lorstenoplo lorstenoplo commented Jan 4, 2021

Bugs Fixed:

  1. Now you can change pages when clicked on links in the Navbar, for this the users will have to pass the component in the menu prop with the other options
  2. Fixed a css bug with the navbar, it had postion: absolute removed that. Now you can add the page content and it will appear below the navbar
  3. Updated the example folder to demonstrate the page change happening
  4. Fixed the unique key issue of social icons in Mobile Navigation

I think this Closes: #4, closes: #16

@lorstenoplo
Copy link
Contributor Author

This PR should fix the issues : #4 and #16

@austinbaccus
Copy link

I'm still not able to navigate using the navbar.

I passed in each component into the menu property as instructed, and I just downloaded this yesterday.

menu={[ { name: "HOME", to: "/", component: {Feed} }, { name: "ABOUT ME", to: "/about", component: {About} }, { name: "CONTACT", to: "/contact", component: {Contact} }, ]}

I still have to manually refresh the page after clicking on a navbar link to actually navigate to the page.

@lorstenoplo
Copy link
Contributor Author

@austinbaccus you haven't followed the example properly.
It should be component: Home that's it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants