Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image loading bugs #735

Merged
merged 3 commits into from
Dec 6, 2023
Merged

Fix image loading bugs #735

merged 3 commits into from
Dec 6, 2023

Conversation

alycejenni
Copy link
Member

  • views now only render once each, instead of recreating themselves after a couple of seconds
  • the image loader checks for abort signals
  • loading status is now turned off after images have loaded, not before
  • images aren't unnecessarily reloaded in the gallery
  • loaded images are sorted so results are consistent

Fixes #731 (hopefully)

@alycejenni
fix: add key to parent div to prevent view rerendering
f68c2b6 
possibly related to vuejs/vue#10331
@alycejenni
fix: remove extra unnecessary image load in gallery component
a801577
@alycejenni
fix: check for aborted requests, sort images, move loading
0b5719b 
loadAndCheckImages now checks at multiple stages if the search request has been aborted, and clears the results if it has.
images are now also sorted properly so the results appear consistently in the correct order.
the loading state is now turned off after images are loaded, not before.
@alycejenni alycejenni merged commit a2dc665 into dev Dec 6, 2023
2 checks passed
@alycejenni alycejenni deleted the ginger/gallery-bug branch December 6, 2023 11:43
@alycejenni alycejenni mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alycejenni