Replace deprecated OptionBuilder with Option.builder() #2488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foster33
reviewed
Aug 1, 2024
...house/ingest-core/src/main/java/datawave/ingest/util/GenerateMultipleNumShardsCacheFile.java
Outdated
Show resolved
Hide resolved
|
Does it make sense to remove the OptionBuilderTest unit tests too? |
ivakegg
previously approved these changes
Sep 4, 2024
SethSmucker
force-pushed
the
task/replace-deprecated-option-builder
branch
from
44d7443
to
98ac1ab
Compare
ivakegg
approved these changes
Sep 6, 2024
ivakegg
reviewed
Sep 12, 2024
| // options.addOption(Option.builder("u").argName("Username").hasArg().required().desc("Accumulo username").build()); | ||
| options.addOption(Option.builder(CONFIG_DIRECTORY_LOCATION_OVERRIDE).argName("Config Directory Path").hasArg().required().desc("Config directory path") | ||
| .build()); | ||
| options.addOption(Option.builder(CONFIG_SUFFIX_OVERRIDE).argName("Config Suffix").hasArg().required().desc("Config file suffix").build()); |
There was a problem hiding this comment.
This one is not required. Caught this as it broke in integration testing.
ivakegg
requested changes
Sep 12, 2024
ivakegg
approved these changes
Oct 9, 2024
apmoriarty
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following classes have been updated to use Option.builder() instead of the deprecated class OptionBuilder:
part of #2443