Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sync API clarify response, remove operation name in UI #3247

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

bodinsamuel
Copy link
Collaborator

Changes

Various small changes

  • Return an actual JSON for /sync/start,pause,trigger
  • Remove the operation name in the log UI

@bodinsamuel bodinsamuel self-assigned this Jan 6, 2025
@bodinsamuel bodinsamuel requested a review from a team January 6, 2025 11:32
@bodinsamuel bodinsamuel enabled auto-merge (squash) January 6, 2025 17:38
Copy link

gitguardian bot commented Jan 6, 2025

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
8205899 Triggered Generic Password 557646b packages/database/lib/getConfig.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@bodinsamuel bodinsamuel merged commit 703e5b0 into master Jan 6, 2025
20 checks passed
@bodinsamuel bodinsamuel deleted the sam/25_01_06/fix/api-start-pause-response branch January 6, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants