Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(server): Add application name to db config #3214

Merged
merged 4 commits into from
Jan 6, 2025
Merged

Conversation

nalanj
Copy link
Contributor

@nalanj nalanj commented Dec 20, 2024

We weren't including application_name in our PG connections, which in turn made it more difficult to look at state in the db server and its logs.

Deployment:

  • Set NANGO_DB_APPLICATION_NAME for server
  • Add application_name param to ORCHESTRATOR_DATABASE_URL
  • Set NANGO_DB_APPLICATION_NAME for jobs
  • Set RECORDS_DATABASE_URL on jobs with application_name
  • Set RECORDS_DATABASE_URL on persist with application_name
  • Set RECORDS_DATABASE_URL on server with application_name
  • Set RECORDS_DATABASE_URL on orchestrator with application_name

@nalanj nalanj self-assigned this Dec 20, 2024
Copy link

gitguardian bot commented Dec 20, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
8205899 Triggered Generic Password 2547c14 packages/database/lib/getConfig.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@nalanj nalanj requested a review from a team December 20, 2024 21:09
@nalanj nalanj marked this pull request as ready for review December 20, 2024 21:09
packages/database/lib/getConfig.ts Outdated Show resolved Hide resolved
@nalanj nalanj merged commit bee1307 into master Jan 6, 2025
33 checks passed
@nalanj nalanj deleted the alan/pg-app-name branch January 6, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants