Skip to content

Commit

Permalink
conditional volume
Browse files Browse the repository at this point in the history
  • Loading branch information
khaliqgant committed Jan 10, 2024
1 parent 1dc1eea commit f12a3be
Show file tree
Hide file tree
Showing 8 changed files with 21 additions and 7 deletions.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ helm delete nango
| | DB_SSL | false |
| | ENCRYPTION_KEY | "" |
| | CALLBACK_URL | "" |
| | flows_path | /flows |
| | useVolumeForFlows | true |
| temporalio | volumeName | temporal-secrets |
| | TEMPORAL_ADDRESS | nango-sync.abc |
| | TEMPORAL_NAMESPACE | nango-sync.def |
Expand Down
2 changes: 1 addition & 1 deletion charts/nango/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
apiVersion: v2
name: nango
type: application
version: 0.0.5
version: 0.0.6
appVersion: 0.0.2
dependencies:
- condition: postgresql.enabled
Expand Down
2 changes: 1 addition & 1 deletion charts/nango/templates/jobs/jobs-aws-storage-class.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if .Values.jobs.volume.aws }}
{{- if .Values.shared.useVolumeForFlows .Values.jobs.volume.aws }}
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
Expand Down
8 changes: 6 additions & 2 deletions charts/nango/templates/jobs/jobs-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,16 +46,20 @@ spec:
- name: NANGO_ENTERPRISE
value: "false"
- name: NANGO_INTEGRATIONS_FULL_PATH
value: /flows
value: {{ .Values.shared.flows_path }}
volumeMounts:
- mountPath: /flows
{{- if .Values.shared.useVolumeForFlows }}
- mountPath: {{ .Values.shared.flows_path }}
name: {{ .Values.jobs.volume.name }}
{{- end }}
- mountPath: /etc/secrets/
name: {{ .Values.temporalio.volumeName }}
volumes:
{{- if .Values.shared.useVolumeForFlows }}
- name: {{ .Values.jobs.volume.name }}
persistentVolumeClaim:
claimName: {{ .Values.jobs.volume.claimName }}
{{- end }}
- name: {{ .Values.temporalio.volumeName }}
secret:
secretName: {{ .Values.temporalio.volumeName }}
2 changes: 1 addition & 1 deletion charts/nango/templates/jobs/jobs-gcp-storage-class.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{{- if .Values.jobs.volume.gcp }}
{{- if .Values.shared.useVolumeForFlows .Values.jobs.volume.gcp }}
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
Expand Down
2 changes: 2 additions & 0 deletions charts/nango/templates/jobs/jobs-pvc.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.shared.useVolumeForFlows }}
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
Expand All @@ -10,3 +11,4 @@ spec:
resources:
requests:
storage: 1Gi
{{- end }}
8 changes: 6 additions & 2 deletions charts/nango/templates/server/server-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,16 +55,20 @@ spec:
- name: NANGO_ENTERPRISE
value: "true"
- name: NANGO_INTEGRATIONS_FULL_PATH
value: /flows
value: {{ .Values.shared.flows_path }}
volumeMounts:
- mountPath: /flows
{{- if .Values.shared.useVolumeForFlows }}
- mountPath: {{ .Values.shared.flows_path }}
name: {{ .Values.jobs.volume.name }}
{{- end }}
- mountPath: /etc/secrets/
name: {{ .Values.temporalio.volumeName }}
volumes:
{{- if .Values.shared.useVolumeForFlows }}
- name: {{ .Values.jobs.volume.name }}
persistentVolumeClaim:
claimName: {{ .Values.jobs.volume.claimName }}
{{- end }}
- name: {{ .Values.temporalio.volumeName }}
secret:
secretName: {{ .Values.temporalio.volumeName }}
2 changes: 2 additions & 0 deletions charts/nango/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,8 @@ shared:
DB_SSL: false
ENCRYPTION_KEY: ""
CALLBACK_URL: ""
flows_path: /flows
useVolumeForFlows: true

temporalio:
volumeName: temporal-secrets
Expand Down

0 comments on commit f12a3be

Please sign in to comment.