Fix ISM-expecting tests by explicilty requisting random access. (apac…

…he#31149)
Naireen · May 1, 2024 · d2db322 · d2db322
1 parent dc5841d
commit d2db322
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/...w-java/src/test/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslatorTest.java b/...w-java/src/test/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslatorTest.java
@@ -948,7 +948,9 @@ public void testToList() throws Exception {
     Pipeline pipeline = Pipeline.create(options);
 
     final PCollectionView<List<Integer>> view =
-        pipeline.apply("CreateSideInput", Create.of(11, 13, 17, 23)).apply(View.asList());
+        pipeline
+            .apply("CreateSideInput", Create.of(11, 13, 17, 23))
+            .apply(View.<Integer>asList().withRandomAccess());
 
     pipeline
         .apply("CreateMainInput", Create.of(29, 31))

diff --git a/.../worker/src/test/java/org/apache/beam/runners/dataflow/worker/IsmSideInputReaderTest.java b/.../worker/src/test/java/org/apache/beam/runners/dataflow/worker/IsmSideInputReaderTest.java
@@ -678,7 +678,9 @@ public void testList() throws Exception {
             KV.of(2L, valueInGlobalWindow(62L)));
 
     final PCollectionView<List<Long>> view =
-        Pipeline.create().apply(Create.empty(VarLongCoder.of())).apply(View.asList());
+        Pipeline.create()
+            .apply(Create.empty(VarLongCoder.of()))
+            .apply(View.<Long>asList().withRandomAccess());
 
     Source sourceA = initInputFile(fromKvsForList(firstElements), ismCoder);
     Source sourceB = initInputFile(fromKvsForList(secondElements), ismCoder);
@@ -736,7 +738,7 @@ public void testListInWindow() throws Exception {
         Pipeline.create()
             .apply(Create.empty(VarLongCoder.of()))
             .apply(Window.into(FixedWindows.of(Duration.millis(10))))
-            .apply(View.asList());
+            .apply(View.<Long>asList().withRandomAccess());
 
     Source sourceA = initInputFile(fromKvsForList(concat(firstElements, secondElements)), ismCoder);
     Source sourceB = initInputFile(fromKvsForList(thirdElements), ismCoder);