Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/upgrade to support newest possible version of GMA SDK #23

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Feature/upgrade to support newest possible version of GMA SDK #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ae88b1a
Full screen solution for inline player crash
manojalwisnz Oct 18, 2023
bf3cd5b
added pre-roll add close button to fullscren view
manojalwisnz Oct 25, 2023
de79284
NAT-28585: fixed ad timer issue on full screen
Oct 27, 2023
5aaeaa9
Merge pull request #22 from NZME/NAT-28585-ad-timer-not-showing-corre…
manojalwisnz Oct 27, 2023
4b6bcb8
removed ad close button
manojalwisnz Oct 31, 2023
1bef63e
added ad resume button when app whent to inactive state and come back…
manojalwisnz Nov 1, 2023
a56a590
1. on Android, upgrade to support GMA SDK version 22.6.0; on iOS, upg…
jazdance Feb 15, 2024
b777be2
according to release note, for GMA SDK 22.6.0, it requires compleSdkV…
jazdance Feb 21, 2024
b0fde25
because the external GDPR module only supports GMA SDK 22.4.0, so we …
jazdance Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ def safeExtGet(prop, fallback) {
}

android {
compileSdkVersion safeExtGet('BrightcoveImaPlayer_compileSdkVersion', 29)
compileSdkVersion safeExtGet('BrightcoveImaPlayer_compileSdkVersion', 33)
defaultConfig {
minSdkVersion safeExtGet('BrightcoveImaPlayer_minSdkVersion', 19)
targetSdkVersion safeExtGet('BrightcoveImaPlayer_targetSdkVersion', 29)
minSdkVersion safeExtGet('BrightcoveImaPlayer_minSdkVersion', 24)
targetSdkVersion safeExtGet('BrightcoveImaPlayer_targetSdkVersion', 33)
versionCode 1
versionName "1.0"

Expand Down
2 changes: 1 addition & 1 deletion android/constants.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
project.ext {
BRIGHTCOVE_VERSION = '6.18.6'
PLAY_SERVICES_VERSION = '20.3.0'
PLAY_SERVICES_VERSION = '22.4.0'
GOOGLE_IMA_SDK_VERSION = '3.21.1'
ANDROIDX_LEGACY_SUPPORT_V4 = '1.0.0'
ANDROIDX_MEDIA = '1.1.0'
Expand Down
Loading