Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFR-1720: Cleanup eslint plugins and linting errors #560

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

jackiequach
Copy link
Collaborator

Jira Ticket

This PR does the following:

  • Removes some eslint plugins since eslint-config-next includes recommended rulesets for React, React Hooks, and Next
  • Resolve lint errors from enabling TypeScript and testing-library ruleset

Testing requirements & instructions:

Copy link

vercel bot commented Nov 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sfr-bookfinder-front-end ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 18, 2024 7:37pm

Copy link
Contributor

@samanthaandrews samanthaandrews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! Feels good to remove those extra packages and update the linting.

@jackiequach jackiequach merged commit 7f825c0 into development Nov 19, 2024
8 checks passed
@jackiequach jackiequach deleted the SFR-1720/cleanup-eslint-plugins branch November 19, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants