Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SFR-2313: Cleanup scss files #559

Merged
merged 3 commits into from
Nov 15, 2024
Merged

SFR-2313: Cleanup scss files #559

merged 3 commits into from
Nov 15, 2024

Conversation

jackiequach
Copy link
Collaborator

Jira Ticket

This PR does the following:

  • Remove unused scss and img files
  • Fix minor styling issue on landing page

Testing requirements & instructions:

@vercel Vercel
Copy link

vercel bot commented Nov 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sfr-bookfinder-front-end ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2024 8:56pm

kylevillegas93
kylevillegas93 approved these changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@kylevillegas93 kylevillegas93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Recommend just doing a spot check once these changes are merged into QA!

@jackiequach jackiequach merged commit dcd142f into development Nov 15, 2024
8 checks passed
@jackiequach jackiequach deleted the SFR-2313/cleanup-scss-files branch November 15, 2024 21:06
@samanthaandrews
Copy link
Contributor

In a follow up PR we might want to figure out a singular, consistent place to store the CSS that is in the _document.tsx file. Right now we have some styles in the main.scss file and some in _document.tsx which can get confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylevillegas93 kylevillegas93 kylevillegas93 approved these changes

@samanthaandrews samanthaandrews Awaiting requested review from samanthaandrews samanthaandrews is a code owner

@kristojorg kristojorg Awaiting requested review from kristojorg

@Toxiapo Toxiapo Awaiting requested review from Toxiapo

@oliviawongnyc oliviawongnyc Awaiting requested review from oliviawongnyc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackiequach @samanthaandrews @kylevillegas93