Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-REF: Fixing docker file and playwright tests #547

Merged
merged 10 commits into from
Oct 25, 2024
Merged

Conversation

kylevillegas93
Copy link
Contributor

@kylevillegas93 kylevillegas93 commented Oct 23, 2024

This PR does the following:

  • Fixes the docker deploy by setting the environment variables before running npm run dev

Testing requirements & instructions:

docker compose up
npm run dev; npm run playwright

Screenshot 2024-10-23 at 15 30 36 Screenshot 2024-10-24 at 12 51 08

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sfr-bookfinder-front-end ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 24, 2024 4:59pm

@@ -1,5 +1,3 @@
version: "3"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version is obsolete!

@kylevillegas93 kylevillegas93 changed the title NO-REF: Fixing docker deploy NO-REF: Fixing docker file Oct 24, 2024
@kylevillegas93 kylevillegas93 changed the title NO-REF: Fixing docker file NO-REF: Fixing docker file and playwright tests Oct 24, 2024
Copy link
Contributor

@ayan1229 ayan1229 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kylevillegas93 kylevillegas93 merged commit 5556a42 into development Oct 25, 2024
7 checks passed
@kylevillegas93 kylevillegas93 deleted the fix-deploy branch October 25, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants