Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFR 2238/run gha on local #537

Merged
merged 5 commits into from
Oct 22, 2024
Merged

SFR 2238/run gha on local #537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3be5682
SFR-2238: Run GHA on Local
ayan1229 Oct 15, 2024
d7d914a
SFR-2238: run gha on localhost
ayan1229 Oct 15, 2024
2772348
revert newrelic changes on package.json
ayan1229 Oct 15, 2024
5479c19
update the app url in cucumber.json
ayan1229 Oct 15, 2024
ed86229
remove wait steps from playwright.yml
ayan1229 Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/Playwright.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,18 @@ jobs:
with:
node-version-file: ".nvmrc"

- name: Install Docker
uses: docker/setup-buildx-action@v2

- name: Build and Run Docker Compose
run: |
docker-compose up -d
working-directory: ./sfr-bookfinder-front-end

- name: Update /etc/hosts
run: |
echo "127.0.0.1 local.nypl.org" | sudo tee -a /etc/hosts

- name: Install Deps
run: npm i @cucumber/[email protected] @playwright/[email protected]

Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
- Add error logging to New Relic for API route errors and client side errors
- Update `actions/checkout`, `actions/setup-node`, `aws-actions/configure-aws-credentials`, and `aws-actions/amazon-ecr-login` Github action versions
- Update unit tests to use custom render function
- SFR-2238: Run GHA on Localhost

## [0.18.2]

Expand Down
2 changes: 1 addition & 1 deletion cucumber.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"default": {
"import": ["playwright/tests/**/*.ts", "playwright/support/**/*.ts"],
"worldParameters": {
"appUrl": "https://drb-qa.nypl.org",
"appUrl": "http://localhost:3000",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If login is tested you may want to use local.nypl.org

"headless": false
}
}
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading