SFR-2200: Update license page to copyright #534
Conversation
jackiequach
requested review from
samanthaandrews,
kristojorg,
Toxiapo and
oliviawongnyc
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| <h2 | ||
| class="chakra-heading css-1xdhyk6" | ||
| > | ||
| In Copyright | ||
| </h2> | ||
| <p> | ||
| Works that are | ||
|
|
||
| <a | ||
| class="chakra-link css-qsaw8" | ||
| href="https://rightsstatements.org/page/InC/1.0/?language=en" | ||
| > | ||
| In Copyright | ||
| </a> | ||
|
|
||
| are protected by copyright and/or related rights. You are free to use this Item in any way that is permitted by the copyright and related rights legislation that applies to your use. For other uses you need to obtain permission from the rights-holder(s). |
There was a problem hiding this comment.
Sorry this is the file! Ha
I think this is ok to leave as is but it requires us to change this language every time we want to update the Copyright page. Is there a more robust test that we can write that is more agnostic to the content of the page?
There was a problem hiding this comment.
Added unit tests to test different parts of the page.
| <Heading level="h2">In Copyright</Heading> | ||
| <p> | ||
| Works that are{" "} | ||
| <Link to="https://rightsstatements.org/page/InC/1.0/?language=en"> | ||
| In Copyright | ||
| </Link>{" "} | ||
| are protected by copyright and/or related rights. You are free to use | ||
| this Item in any way that is permitted by the copyright and related | ||
| rights legislation that applies to your use. For other uses you need to | ||
| obtain permission from the rights-holder(s). | ||
| </p> |
There was a problem hiding this comment.
Is there an updated BRD? I see that this is the language reflected in the ticket but not here: https://docs.google.com/document/d/12WVwIxC_OT3eWcw8-LQd1U-FX91tj-qWnL8A6d0CLsU/edit
Also https://rightsstatements.org/vocab/InC/1.0/ unfortunately is returning a Bad Gateway. I'd let Will know and have him make a decision on whether we want to include it or not.
| import { screen } from "@testing-library/react"; | ||
| import Copyright from "./Copyright"; | ||
|
|
||
| it("renders Copyright page unchanged", async () => { |
There was a problem hiding this comment.
Nice - I really like this test - ensures we have the right sections!
Jira Ticket
This PR does the following:
Testing requirements & instructions: