Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SFR-2056: Update proxyUrl for limited access books #509

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

jackiequach
Copy link
Collaborator

Jira Ticket

This PR does the following:

  • Only pass the proxyUrl to the web reader when the resource is not internally hosted (limited access books)

Testing requirements & instructions:

Copy link

vercel bot commented Jul 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sfr-bookfinder-front-end ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 3:32pm

Copy link
Contributor

@kylevillegas93 kylevillegas93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Are there any other cases where we don't necessarily need to use the proxy?

@jackiequach
Copy link
Collaborator Author

@kylevillegas93 The proxy isn't used when ePubs/html resources are passed, but that is already handled on the web reader side. I don't believe we host any resources other than limited access.

@jackiequach jackiequach merged commit da2bd39 into development Jul 25, 2024
12 checks passed
@jackiequach jackiequach deleted the SFR-2056/remove-internal-proxy branch July 25, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants